mirrors/LibHac
1
0
Fork 0
mirror of https://github.com/Thealexbarney/LibHac.git synced 2024-11-14 10:49:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use runtime instead of compile-time conditionals for result logging

Browse source
This commit is contained in:
Alex Barney 2019-12-17 22:15:16 -06:00
parent 47f2f4954a
commit 2b828bb50f
2 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.gitignore vendored
View file

@ -264,4 +264,5 @@ __pycache__/
global.json global.json
!tests/LibHac.Tests/CryptoTests/TestVectors/* !tests/LibHac.Tests/CryptoTests/TestVectors/*
**/DisasmoBin/

22
src/LibHac/Result.cs
View file

@ -42,9 +42,8 @@ namespace LibHac
/// <returns>The called <see cref="Result"/> value.</returns> /// <returns>The called <see cref="Result"/> value.</returns>
public Result Log() public Result Log()
{ {
#if DEBUG LogImpl();
LogCallback?.Invoke(this);
#endif
return this; return this;
} }
@ -55,12 +54,23 @@ namespace LibHac
/// <returns>The called <see cref="Result"/> value.</returns> /// <returns>The called <see cref="Result"/> value.</returns>
public Result LogConverted(Result originalResult) public Result LogConverted(Result originalResult)
{ {
#if DEBUG LogConvertedImpl(originalResult);
ConvertedLogCallback?.Invoke(this, originalResult);
#endif
return this; return this;
} }
[Conditional("DEBUG")]
private void LogImpl()
{
LogCallback?.Invoke(this);
}
[Conditional("DEBUG")]
private void LogConvertedImpl(Result originalResult)
{
ConvertedLogCallback?.Invoke(this, originalResult);
}
public delegate void ResultLogger(Result result); public delegate void ResultLogger(Result result);
public delegate void ConvertedResultLogger(Result result, Result originalResult); public delegate void ConvertedResultLogger(Result result, Result originalResult);
public delegate bool ResultNameGetter(Result result, out string name); public delegate bool ResultNameGetter(Result result, out string name);