From 857bde67eea3b965ef70356e8af7bbd918b30db4 Mon Sep 17 00:00:00 2001
From: Alex Barney <thealexbarney@gmail.com>
Date: Fri, 17 Jan 2020 00:01:25 -0700
Subject: [PATCH] Simplify CoreRT build

---
 build/Build.cs                         | 77 +++++++++-----------------
 nuget.config                           |  6 ++
 src/hactoolnet/hactoolnet.csproj       | 23 +++++++-
 tests/LibHac.Tests/LibHac.Tests.csproj |  2 +-
 4 files changed, 54 insertions(+), 54 deletions(-)
 create mode 100644 nuget.config

diff --git a/build/Build.cs b/build/Build.cs
index 3f6b73d2..0b1d0012 100644
--- a/build/Build.cs
+++ b/build/Build.cs
@@ -7,7 +7,6 @@ using System.Linq;
 using System.Security.Cryptography;
 using System.Text;
 using System.Text.RegularExpressions;
-using System.Xml.Linq;
 using ICSharpCode.SharpZipLib.Zip;
 using Nuke.Common;
 using Nuke.Common.CI.AppVeyor;
@@ -43,10 +42,9 @@ namespace LibHacBuild
         AbsolutePath TempDirectory => RootDirectory / ".tmp";
         AbsolutePath CliCoreDir => TempDirectory / "hactoolnet_netcoreapp3.1";
         AbsolutePath CliNativeDir => TempDirectory / $"hactoolnet_{HostOsName}";
-        AbsolutePath CliNativeExe => CliNativeDir / $"hactoolnet_native{NativeProgramExtension}";
+        AbsolutePath CliNativeExe => CliNativeDir / $"hactoolnet{NativeProgramExtension}";
         AbsolutePath CliCoreZip => ArtifactsDirectory / $"hactoolnet-{VersionString}-netcore.zip";
         AbsolutePath CliNativeZip => ArtifactsDirectory / $"hactoolnet-{VersionString}-{HostOsName}.zip";
-        AbsolutePath NugetConfig => RootDirectory / "nuget.config";
 
         Project LibHacProject => _solution.GetProject("LibHac").NotNull();
         Project LibHacTestProject => _solution.GetProject("LibHac.Tests").NotNull();
@@ -61,7 +59,6 @@ namespace LibHacBuild
         string VersionString { get; set; }
         Dictionary<string, object> VersionProps { get; set; } = new Dictionary<string, object>();
 
-        private const string DotNetFeedSource = "https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json";
         const string CertFileName = "cert.pfx";
 
         public Build()
@@ -270,6 +267,8 @@ namespace LibHacBuild
                     .Concat(Directory.EnumerateFiles(CliCoreDir, "*.dll"))
                     .ToArray();
 
+                EnsureExistingDirectory(ArtifactsDirectory);
+
                 ZipFiles(CliCoreZip, namesCore);
                 Logger.Normal($"Created {CliCoreZip}");
 
@@ -352,58 +351,32 @@ namespace LibHacBuild
         [SuppressMessage("ReSharper", "PossibleNullReferenceException")]
         public void BuildNative()
         {
-            AbsolutePath nativeProject = HactoolnetProject.Path.Parent / "hactoolnet_native.csproj";
+            string buildType = Untrimmed ? "native-untrimmed" : "native";
 
-            try
+            DotNetPublishSettings publishSettings = new DotNetPublishSettings()
+                .SetConfiguration(Configuration)
+                .SetProject(HactoolnetProject)
+                .SetRuntime(NativeRuntime)
+                .SetOutput(CliNativeDir)
+                .SetProperties(VersionProps)
+                .AddProperty("BuildType", buildType);
+
+            DotNetPublish(publishSettings);
+
+            if (EnvironmentInfo.IsUnix && !Untrimmed)
             {
-                File.Copy(HactoolnetProject, nativeProject, true);
-                DotNet("new nuget --force");
-
-                XDocument doc = XDocument.Load(NugetConfig);
-                doc.Element("configuration").Element("packageSources").Add(new XElement("add",
-                    new XAttribute("key", "myget"), new XAttribute("value", DotNetFeedSource)));
-
-                doc.Save(NugetConfig);
-
-                DotNet($"add {nativeProject} package Microsoft.DotNet.ILCompiler --version 1.0.0-alpha-*");
-
-                DotNetPublishSettings publishSettings = new DotNetPublishSettings()
-                    .SetConfiguration(Configuration)
-                    .SetProject(nativeProject)
-                    .SetFramework("netcoreapp3.1")
-                    .SetRuntime(NativeRuntime)
-                    .SetOutput(CliNativeDir)
-                    .SetProperties(VersionProps);
-
-                if (!Untrimmed)
-                {
-                    publishSettings = publishSettings
-                            .AddProperty("RootAllApplicationAssemblies", false)
-                            .AddProperty("IlcGenerateCompleteTypeMetadata", false)
-                            .AddProperty("IlcGenerateStackTraceData", false)
-                            .AddProperty("IlcFoldIdenticalMethodBodies", true)
-                        ;
-                }
-
-                DotNetPublish(publishSettings);
-
-                if (EnvironmentInfo.IsUnix && !Untrimmed)
-                {
-                    ProcessTasks.StartProcess("strip", CliNativeExe).AssertZeroExitCode();
-                }
-
-                ZipFile(CliNativeZip, CliNativeExe, $"hactoolnet{NativeProgramExtension}");
-                Logger.Normal($"Created {CliNativeZip}");
-
-                if (Host == HostType.AppVeyor)
-                {
-                    PushArtifact(CliNativeZip);
-                }
+                File.Copy(CliNativeExe, CliNativeExe + "_unstripped");
+                ProcessTasks.StartProcess("strip", CliNativeExe).AssertZeroExitCode();
             }
-            finally
+
+            EnsureExistingDirectory(ArtifactsDirectory);
+
+            ZipFile(CliNativeZip, CliNativeExe, $"hactoolnet{NativeProgramExtension}");
+            Logger.Normal($"Created {CliNativeZip}");
+
+            if (Host == HostType.AppVeyor)
             {
-                File.Delete(nativeProject);
-                File.Delete(NugetConfig);
+                PushArtifact(CliNativeZip);
             }
         }
 
diff --git a/nuget.config b/nuget.config
new file mode 100644
index 00000000..41b398ea
--- /dev/null
+++ b/nuget.config
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<configuration>
+  <packageSources>
+    <add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
+  </packageSources>
+</configuration>
diff --git a/src/hactoolnet/hactoolnet.csproj b/src/hactoolnet/hactoolnet.csproj
index c5e67e5a..d53846bc 100644
--- a/src/hactoolnet/hactoolnet.csproj
+++ b/src/hactoolnet/hactoolnet.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFrameworks>netcoreapp3.1</TargetFrameworks>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
     <LangVersion>8.0</LangVersion>
   </PropertyGroup>
 
@@ -20,4 +20,25 @@
     <ProjectReference Include="..\LibHac\LibHac.csproj" />
   </ItemGroup>
 
+  <!-- Options for use with CoreRT -->
+  <ItemGroup Condition=" $(BuildType.StartsWith('native')) ">
+    <PackageReference Include="Microsoft.DotNet.ILCompiler" Version="1.0.0-alpha-*" />
+  </ItemGroup>
+
+  <PropertyGroup Condition=" $(BuildType.StartsWith('native')) and '$(BuildType)' != 'native-untrimmed' ">
+    <IlcFoldIdenticalMethodBodies>true</IlcFoldIdenticalMethodBodies>
+    <IlcGenerateCompleteTypeMetadata>false</IlcGenerateCompleteTypeMetadata>
+    <IlcOptimizationPreference>Speed</IlcOptimizationPreference>
+    <RootAllApplicationAssemblies>false</RootAllApplicationAssemblies>
+  </PropertyGroup>
+
+  <ItemGroup Condition=" $(BuildType.StartsWith('native')) and '$(BuildType)' != 'native-untrimmed' ">
+    <IlcArg Include="--removefeature:EventSource" />
+  </ItemGroup>
+
+  <!-- No-reflection mode doesn't work yet -->
+  <PropertyGroup Condition=" '$(BuildType)' == 'native-noreflection' ">
+    <IlcDisableReflection>true</IlcDisableReflection>
+  </PropertyGroup>
+
 </Project>
diff --git a/tests/LibHac.Tests/LibHac.Tests.csproj b/tests/LibHac.Tests/LibHac.Tests.csproj
index ee2c2200..3ebc86d8 100644
--- a/tests/LibHac.Tests/LibHac.Tests.csproj
+++ b/tests/LibHac.Tests/LibHac.Tests.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp3.1</TargetFrameworks>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
 
     <IsPackable>false</IsPackable>
   </PropertyGroup>