From 487ba39bbfc4c6092840ca9fccd625e9d75421e3 Mon Sep 17 00:00:00 2001
From: Jelle van Snik <jellevs@gmail.com>
Date: Sat, 4 Feb 2023 19:18:14 +0100
Subject: [PATCH] update todos and remove test view

---
 src/index.tsx          | 11 +++++-----
 src/setup/App.tsx      |  3 ---
 src/views/TestView.tsx | 46 ------------------------------------------
 3 files changed, 6 insertions(+), 54 deletions(-)
 delete mode 100644 src/views/TestView.tsx

diff --git a/src/index.tsx b/src/index.tsx
index 080b9712..4bcf297d 100644
--- a/src/index.tsx
+++ b/src/index.tsx
@@ -19,12 +19,13 @@ if (key) {
 initializeChromecast();
 
 // TODO video todos:
-//  - mobile controls start showing when resizing
-//  - bug: popouts sometimes stop working when selecting different episode
 //  - captions
 //  - chrome cast support
-//  - safari fullscreen will make video overlap player controls
-//  - safari progress bar is fucked (video doesnt change time but video.currentTime does change)
+//  - bug: mobile controls start showing when resizing
+//  - bug: popouts sometimes stop working when selecting different episode
+//  - bug: unmounting player throws errors in console
+//  - bug: safari fullscreen will make video overlap player controls
+//  - bug: safari progress bar is fucked (video doesnt change time but video.currentTime does change)
 
 // TODO stuff to test:
 //  - browser: firefox, chrome, edge, safari desktop
@@ -40,7 +41,7 @@ initializeChromecast();
 //  - AFTER all that: rank providers/embedscrapers
 
 // TODO general todos:
-//  - localize everything (fix loading screen text (series vs movies)) (and have EN file instead)
+//  - localize everything (fix loading screen text (series vs movies)) (and have EN file instead of en-gb)
 
 ReactDOM.render(
   <React.StrictMode>
diff --git a/src/setup/App.tsx b/src/setup/App.tsx
index 5f1b2b11..6ab1374c 100644
--- a/src/setup/App.tsx
+++ b/src/setup/App.tsx
@@ -6,9 +6,7 @@ import { NotFoundPage } from "@/views/notfound/NotFoundView";
 import { MediaView } from "@/views/media/MediaView";
 import { SearchView } from "@/views/search/SearchView";
 import { MWMediaType } from "@/backend/metadata/types";
-import { TestView } from "@/views/TestView";
 
-// TODO remove test view
 function App() {
   return (
     <WatchedContextProvider>
@@ -18,7 +16,6 @@ function App() {
             <Redirect to={`/search/${MWMediaType.MOVIE}`} />
           </Route>
           <Route exact path="/media/:media" component={MediaView} />
-          <Route exact path="/test" component={TestView} />
           <Route
             exact
             path="/media/:media/:season/:episode"
diff --git a/src/views/TestView.tsx b/src/views/TestView.tsx
deleted file mode 100644
index 5436207b..00000000
--- a/src/views/TestView.tsx
+++ /dev/null
@@ -1,46 +0,0 @@
-// import {
-//   useChromecast,
-//   useChromecastAvailable,
-// } from "@/hooks/useChromecastAvailable";
-// import { useEffect, useRef } from "react";
-
-import { MWStreamQuality, MWStreamType } from "@/backend/helpers/streams";
-// import { MWMediaType } from "@/backend/metadata/types";
-// import { MetaController } from "@/video/components/controllers/MetaController";
-import { SourceController } from "@/video/components/controllers/SourceController";
-import { VideoPlayer } from "@/video/components/VideoPlayer";
-
-// function ChromeCastButton() {
-//   const ref = useRef<HTMLDivElement>(null);
-//   const available = useChromecastAvailable();
-
-//   useEffect(() => {
-//     if (!available) return;
-//     const tag = document.createElement("google-cast-launcher");
-//     tag.setAttribute("id", "castbutton");
-//     ref.current?.appendChild(tag);
-//   }, [available]);
-
-//   return <div ref={ref} />;
-// }
-
-export function TestView() {
-  return (
-    <VideoPlayer onGoBack={() => alert("hello world")}>
-      <SourceController
-        quality={MWStreamQuality.QUNKNOWN}
-        source="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/Sintel.mp4"
-        type={MWStreamType.MP4}
-      />
-      {/* <MetaController
-        meta={{
-          id: "test",
-          title: "Hello world",
-          type: MWMediaType.MOVIE,
-          year: "1234",
-          seasons: undefined,
-        }} */}
-      {/* /> */}
-    </VideoPlayer>
-  );
-}