mirrors/smov
mirrors/smov
1
0
Fork 0
mirror of https://github.com/sussy-code/smov.git synced 2024-12-29 16:07:40 +01:00
Code Issues Wiki Activity

Try fixing jank extensionBanner flow

Browse source
This commit is contained in:
Cooper Ransom 2024-04-06 12:44:21 -04:00
parent 366251e143
commit 6e478fd37e
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/setup/Layout.tsx
View file

@ -29,11 +29,11 @@ export function Layout(props: { children: ReactNode }) {
return (
<div>
{extensionState !== "success" && !isMobile && (
{extensionState !== "success" ? (
<div className="fixed inset-x-0 z-[1000]">
<ExtensionBanner extensionState={extensionState} />
</div>
)}
) : null}
<div
style={{
paddingTop: location === null ? `${bannerSize}px` : "0px",

4
src/stores/banner/BannerLocation.tsx
View file

@ -3,6 +3,7 @@ import { Trans, useTranslation } from "react-i18next";
import { useLocation, useNavigate } from "react-router-dom";
import { Icon, Icons } from "@/components/Icon";
import { useIsMobile } from "@/hooks/useIsMobile";
import { useBannerStore, useRegisterBanner } from "@/stores/banner";
import type { ExtensionStatus } from "@/utils/extension";
@ -69,6 +70,7 @@ export function ExtensionBanner(props: {
/CrOS/.test(navigator.userAgent) ||
/TV/.test(navigator.userAgent) ||
/iPhone|iPad|iPod/i.test(navigator.userAgent);
const { isMobile } = useIsMobile();
useEffect(() => {
if (loc) {
@ -88,7 +90,7 @@ export function ExtensionBanner(props: {
return null;
// Show the banner with a 36.5% chance or not if users dont meet requirements
if (!isEligible && Math.random() < 0.365) {
if (!isEligible && !isMobile && Math.random() < 0.365) {
let bannerText = "";
switch (props.extensionState) {
case "noperms":