From 9c159f01bd8f07c17a2b2f58b932a47a8a8a1d9c Mon Sep 17 00:00:00 2001 From: mrjvs Date: Sun, 19 Mar 2023 20:22:44 +0100 Subject: [PATCH] remove lint annotations --- .github/workflows/linting_annotate.yml | 48 ------------------- .github/workflows/linting_testing.yml | 11 +---- .../popouts/EpisodeSelectionPopout.tsx | 7 +++ 3 files changed, 9 insertions(+), 57 deletions(-) delete mode 100644 .github/workflows/linting_annotate.yml diff --git a/.github/workflows/linting_annotate.yml b/.github/workflows/linting_annotate.yml deleted file mode 100644 index 2bc9b613..00000000 --- a/.github/workflows/linting_annotate.yml +++ /dev/null @@ -1,48 +0,0 @@ -name: Annotate linting - -permissions: - actions: read # download artifact - checks: write # annotate - -# this is done as a seperate workflow so -# the annotater has access to write to checks (to annotate) -on: - workflow_run: - workflows: ["Linting and Testing"] - types: - - completed - -jobs: - annotate: - name: Annotate linting - runs-on: ubuntu-latest - - steps: - - name: Download linting report - uses: actions/github-script@v6 - with: - script: | - const artifacts = await github.rest.actions.listWorkflowRunArtifacts({ - owner: context.repo.owner, - repo: context.repo.repo, - run_id: ${{github.event.workflow_run.id }}, - }); - const matchArtifact = artifacts.data.artifacts.filter((artifact) => { - return artifact.name == "eslint_report.json" - })[0]; - const download = await github.rest.actions.downloadArtifact({ - owner: context.repo.owner, - repo: context.repo.repo, - artifact_id: matchArtifact.id, - archive_format: 'zip', - }); - const fs = require('fs'); - fs.writeFileSync('${{github.workspace}}/eslint_report.zip', Buffer.from(download.data)); - - - run: unzip eslint_report.zip - - - name: Annotate linting - uses: ataylorme/eslint-annotate-action@v2 - with: - repo-token: "${{ secrets.GITHUB_TOKEN }}" - report-json: "eslint_report.json" diff --git a/.github/workflows/linting_testing.yml b/.github/workflows/linting_testing.yml index 53d7b5ca..12428aff 100644 --- a/.github/workflows/linting_testing.yml +++ b/.github/workflows/linting_testing.yml @@ -25,15 +25,8 @@ jobs: - name: Install Yarn packages run: yarn install - - name: Run ESLint Report - run: yarn lint:report - # continue on error, so it still reports it in the next step - continue-on-error: true - - - uses: actions/upload-artifact@v3 - with: - name: eslint_report.json - path: eslint_report.json + - name: Run ESLint + run: yarn lint building: name: Build project diff --git a/src/video/components/popouts/EpisodeSelectionPopout.tsx b/src/video/components/popouts/EpisodeSelectionPopout.tsx index 61218170..0db5c14b 100644 --- a/src/video/components/popouts/EpisodeSelectionPopout.tsx +++ b/src/video/components/popouts/EpisodeSelectionPopout.tsx @@ -1,6 +1,13 @@ import React, { useCallback, useMemo, useState } from "react"; import { useParams } from "react-router-dom"; import { Icon, Icons } from "@/components/Icon"; + + + + + + + import { useLoading } from "@/hooks/useLoading"; import { MWMediaType, MWSeasonWithEpisodeMeta } from "@/backend/metadata/types"; import { getMetaFromId } from "@/backend/metadata/getmeta";