From a2e647297a872275c32df48eef264d0b0de5005c Mon Sep 17 00:00:00 2001 From: mrjvs Date: Sun, 19 Feb 2023 23:03:16 +0100 Subject: [PATCH] cleanup todos Co-authored-by: Jip Frijlink Co-authored-by: James Hawkins Co-authored-by: William Oldham --- src/index.tsx | 16 ---------------- src/state/watched/migrations/v2.ts | 1 - .../state/providers/castingStateProvider.ts | 4 +--- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/src/index.tsx b/src/index.tsx index a6f88858..8de72d2c 100644 --- a/src/index.tsx +++ b/src/index.tsx @@ -19,22 +19,6 @@ if (key) { } initializeChromecast(); -// TODO video todos: -// - chrome cast support -// - bug: safari fullscreen will make video overlap player controls - -// TODO stuff to test: -// - browser: firefox, chrome, edge, safari desktop -// - phones: android firefox, android chrome, iphone safari -// - devices: ipadOS -// - HLS -// - HLS error handling -// - video player error handling - -// TODO backend system: -// - implement jons providers/embedscrapers -// - AFTER all that: rank providers/embedscrapers - const LazyLoadedApp = React.lazy(async () => { await initializeStores(); return { diff --git a/src/state/watched/migrations/v2.ts b/src/state/watched/migrations/v2.ts index 0e9c52e8..de3dad44 100644 --- a/src/state/watched/migrations/v2.ts +++ b/src/state/watched/migrations/v2.ts @@ -70,7 +70,6 @@ async function getMetas( let keys: (string | null)[][] = [["0", "0"]]; if (item.data.type === "series") { - // TODO sort episodes by season & episode so it shows the "highest" episode as last const meta = await getMetaFromId(item.data.type, item.data.id); if (!meta || !meta?.meta.seasons) return; const seasonNumbers = [ diff --git a/src/video/state/providers/castingStateProvider.ts b/src/video/state/providers/castingStateProvider.ts index 6c7c66d5..e3b56dfb 100644 --- a/src/video/state/providers/castingStateProvider.ts +++ b/src/video/state/providers/castingStateProvider.ts @@ -17,8 +17,7 @@ import { updateMediaPlaying } from "../logic/mediaplaying"; import { VideoPlayerStateProvider } from "./providerTypes"; import { updateProgress } from "../logic/progress"; -// TODO startAt when switching state providers -// TODO test HLS +// TODO HLS for casting? export function createCastingStateProvider( descriptor: string ): VideoPlayerStateProvider { @@ -184,7 +183,6 @@ export function createCastingStateProvider( break; case "isMuted": state.mediaPlaying.volume = e.value ? 1 : 0; - // TODO better mute handling updateMediaPlaying(descriptor, state); break; case "displayStatus":