From ca180ab9ea171e49e903d9e97f72f52451a245cf Mon Sep 17 00:00:00 2001
From: ssssobek <ssssobek@gmail.com>
Date: Sun, 10 Mar 2024 23:10:25 +0100
Subject: [PATCH] Go back to using percentages instead of pixels

---
 .../player/atoms/settings/CaptionSettingsView.tsx    | 12 ++++--------
 src/components/player/base/SubtitleView.tsx          |  2 +-
 src/pages/parts/settings/CaptionsPart.tsx            | 11 ++++-------
 src/stores/subtitles/index.ts                        |  2 +-
 4 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/src/components/player/atoms/settings/CaptionSettingsView.tsx b/src/components/player/atoms/settings/CaptionSettingsView.tsx
index 936e693d..2e78ed7a 100644
--- a/src/components/player/atoms/settings/CaptionSettingsView.tsx
+++ b/src/components/player/atoms/settings/CaptionSettingsView.tsx
@@ -264,15 +264,11 @@ export function CaptionSettingsView({ id }: { id: string }) {
         />
         <CaptionSetting
           label={t("settings.subtitles.backgroundBlurLabel")}
-          max={64}
+          max={100}
           min={0}
-          onChange={(v) =>
-            updateStyling({
-              backgroundBlur: Math.round(v / 4) * 4,
-            })
-          }
-          value={styling.backgroundBlur}
-          textTransformer={(s) => `${s}px`}
+          onChange={(v) => updateStyling({ backgroundBlur: v / 100 })}
+          value={styling.backgroundBlur * 100}
+          textTransformer={(s) => `${s}%`}
         />
         <CaptionSetting
           label={t("settings.subtitles.textSizeLabel")}
diff --git a/src/components/player/base/SubtitleView.tsx b/src/components/player/base/SubtitleView.tsx
index ebcc7c7c..4f4c6f06 100644
--- a/src/components/player/base/SubtitleView.tsx
+++ b/src/components/player/base/SubtitleView.tsx
@@ -57,7 +57,7 @@ export function CaptionCue({
         backgroundColor: `rgba(0,0,0,${styling.backgroundOpacity.toFixed(2)})`,
         backdropFilter:
           styling.backgroundBlur !== 0
-            ? `blur(${styling.backgroundBlur}px)`
+            ? `blur(${Math.floor(styling.backgroundBlur * 64)}px)`
             : "none",
       }}
     >
diff --git a/src/pages/parts/settings/CaptionsPart.tsx b/src/pages/parts/settings/CaptionsPart.tsx
index 3a16dd25..a6f8ddb5 100644
--- a/src/pages/parts/settings/CaptionsPart.tsx
+++ b/src/pages/parts/settings/CaptionsPart.tsx
@@ -94,16 +94,13 @@ export function CaptionsPart(props: {
           />
           <CaptionSetting
             label={t("settings.subtitles.backgroundBlurLabel")}
-            max={64}
+            max={100}
             min={0}
             onChange={(v) =>
-              props.setStyling({
-                ...props.styling,
-                backgroundBlur: Math.round(v / 4) * 4,
-              })
+              props.setStyling({ ...props.styling, backgroundBlur: v / 100 })
             }
-            value={props.styling.backgroundBlur}
-            textTransformer={(s) => `${s}px`}
+            value={props.styling.backgroundBlur * 100}
+            textTransformer={(s) => `${s}%`}
           />
           <CaptionSetting
             label={t("settings.subtitles.textSizeLabel")}
diff --git a/src/stores/subtitles/index.ts b/src/stores/subtitles/index.ts
index c9ffbca2..b1b535d1 100644
--- a/src/stores/subtitles/index.ts
+++ b/src/stores/subtitles/index.ts
@@ -19,7 +19,7 @@ export interface SubtitleStyling {
   backgroundOpacity: number;
 
   /**
-   * background blur, ranges between 0 and 64
+   * background blur, ranges between 0 and 1
    */
   backgroundBlur: number;
 }